Skip to content

temp fix for nil preemptIDs by qm lib #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

temp fix for nil preemptIDs by qm lib #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
temp fix for nil preemptIDs by qm lib
  • Loading branch information
@asm582
asm582 committed Jul 18, 2023
commit b4c1ef6293b4b862b344f4619b2737341a063039
8 changes: 7 additions & 1 deletion pkg/controller/quota/quotaforestmanager/qm_lib_backend_with_quotasubt_mgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,13 @@ func (qm *QuotaManager) Fits(aw *arbv1.AppWrapper, awResDemands *clusterstateapi
qm.removeConsumer(consumerID)
return doesFit, preemptIds, strings.TrimSpace(allocResponse.GetMessage())
}
preemptIds = qm.getAppWrappers(allocResponse.GetPreemptedIds())
if len(allocResponse.GetPreemptedIds()) > 0 {
preemptIds = qm.getAppWrappers(allocResponse.GetPreemptedIds())
} else {
var s []string
s = append(s, allocResponse.GetConsumerID())
preemptIds = qm.getAppWrappers(s)
}
return doesFit, preemptIds, strings.TrimSpace(allocResponse.GetMessage())
}

Expand Down