Skip to content

Conversation

@z103cb
Copy link
Contributor

@z103cb z103cb commented Jul 18, 2023

Reverting changes to image push out of the build.
Fixes #487

Reverting changes to image push out of the build. Fixes project-codeflare#487
@Srihari1192
Copy link
Contributor

Srihari1192 commented Jul 18, 2023

I assumed that Image push not applicable in case of other than release.
@z103cb Probably we can fix this with condition of release branch to avoid image push incase of release

'if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" != v*]; then make push-images; fi' 
@z103cb
Copy link
Contributor Author

z103cb commented Jul 18, 2023

I assumed that Image push not applicable in case of other than release. @z103cb Probably we can fix this with condition of release branch to avoid image push incase of release

'if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" == v*]; then make push-images; fi' or 'if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" =~ ^v[0-9]\.[0-9]+\.[0-9]+ ]; then make push-images; fi' 

@Srihari1192 thanks for the suggestion, I will amend this PR.

@Srihari1192
Copy link
Contributor

I assumed that Image push not applicable in case of other than release. @z103cb Probably we can fix this with condition of release branch to avoid image push incase of release

'if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" == v*]; then make push-images; fi' or 'if [ "$TRAVIS_PULL_REQUEST" = "false" && "$TRAVIS_BRANCH" =~ ^v[0-9]\.[0-9]+\.[0-9]+ ]; then make push-images; fi' 

@Srihari1192 thanks for the suggestion, I will amend this PR.

Thanks ..Probably we need to test this before merge.. Just correction for above my suggestion it should be not equal to "$TRAVIS_BRANCH" != v*

@z103cb z103cb requested a review from Srihari1192 July 18, 2023 14:24
@z103cb z103cb merged commit de677ec into project-codeflare:main Jul 18, 2023
@z103cb z103cb deleted the z103cb/issue487 branch July 18, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants