Appwrapper invalid template failure fix. Updated to V1.17. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
…after e2e go testing call. Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
Closed
Collaborator Author
| Fix related to issue #49 where pod cause a panic in the controller. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a fix to the panic error by the controller when an invalid pod template is submitted. The controller now handles the casting error and logs the related error. Two additional e2e test we also added 1 podtemplate creation success and 1 podtemplate failure.