updates to use helm3 #212
Closed
updates to use helm3 #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dmatch01 requested changes Aug 17, 2022
| ``` | ||
| export IMAGE=darroyo/mcad-controller | ||
| helm upgrade --install --wait mcad . --namespace kube-system --set loglevel=4 --set image.repository=$IMAGE --set image.tag=quota-management-v1.29.40 --set image.pullPolicy=IfNotPresent --set configMap.name=mcad-controller-configmap --set configMap.quotaEnabled='"false"' --set coscheduler.rbac.apiGroup="scheduling.sigs.k8s.io" --set coscheduler.rbac.resource="podgroups" |
There was a problem hiding this comment.
Can we remove --set coscheduler.rbac.apiGroup="scheduling.sigs.k8s.io" --set coscheduler.rbac.resource="podgroups" as they are not needed for the general case?
There was a problem hiding this comment.
This is the new example that was added to the documentation:
##### Example 5 MCAD supports bring-you-own scheduler use case. To install MCAD with co-scheduler use the follwing command: Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Commands changes to deploy MCAD using helm3