Remove nodes in not ready state #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @asm582 See comments from slack. |
| @dmatch01 Thanks for the review, fixed the bug. Now the code loops through all the conditions and retrieves the status of the |
dmatch01 requested changes Aug 17, 2022
There was a problem hiding this comment.
Please see suggested changes. Also please add a comment in the updated PR to include the testcase(s) run for this PR. Should be something similar to verifying calculations updates after a node is marked as not ready but still schedulable. k drain might be helpful here or even a deletion of the kubelet process (if you have access to the node and can safely restart the kubelet).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Solves #202