Skip to content

pod completion status-1 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

pod completion status-1 #185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
216a7c2
pod completion status-1
asm582 Jun 7, 2022
06a983d
test case
asm582 Jun 8, 2022
c82eddc
completion req flag
asm582 Jun 28, 2022
0fceae5
Add two new states
asm582 Jul 4, 2022
3b3eab7
remove noisy logs
asm582 Jul 4, 2022
b7df0ac
delete log
asm582 Jul 4, 2022
464443b
add debug method
asm582 Jul 18, 2022
17c295d
add debug 1
asm582 Jul 18, 2022
5cf1fc1
add debug 2
asm582 Jul 18, 2022
9779863
changes for pr review
asm582 Jul 19, 2022
23888e4
add delay for test
asm582 Jul 19, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
pod completion status-1 
Signed-off-by: asm582 <asm582@nyu.edu>
  • Loading branch information
@asm582
asm582 committed Jul 4, 2022
commit 216a7c20ef20080a74af7f1d9974727d1253357e
15 changes: 10 additions & 5 deletions pkg/apis/controller/v1beta1/appwrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ limitations under the License.
package v1beta1

import (
"k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
)
Expand Down Expand Up @@ -209,6 +209,9 @@ type AppWrapperStatus struct {
// +optional
Running int32 `json:"running,omitempty" protobuf:"bytes,1,opt,name=running"`

//The total number of running pods which is used to determine Completed status of AW
MaxRunning int32 `json:"runcount,omitempty" protobuf:"bytes,1,opt,name=runcount"`

// The number of resources which reached phase Succeeded.
// +optional
Succeeded int32 `json:"Succeeded,omitempty" protobuf:"bytes,2,opt,name=succeeded"`
Expand Down Expand Up @@ -260,10 +263,11 @@ type AppWrapperState string

//enqueued, active, deleting, succeeded, failed
const (
AppWrapperStateEnqueued AppWrapperState = "Pending"
AppWrapperStateActive AppWrapperState = "Running"
AppWrapperStateDeleted AppWrapperState = "Deleted"
AppWrapperStateFailed AppWrapperState = "Failed"
AppWrapperStateEnqueued AppWrapperState = "Pending"
AppWrapperStateActive AppWrapperState = "Running"
AppWrapperStateDeleted AppWrapperState = "Deleted"
AppWrapperStateFailed AppWrapperState = "Failed"
AppWrapperStateCompleted AppWrapperState = "Completed"
)

type AppWrapperConditionType string
Expand All @@ -279,6 +283,7 @@ const (
AppWrapperCondPreempted AppWrapperConditionType = "Preempted"
AppWrapperCondDeleted AppWrapperConditionType = "Deleted"
AppWrapperCondFailed AppWrapperConditionType = "Failed"
AppWrapperCondCompleted AppWrapperConditionType = "Completed"
)

// DeploymentCondition describes the state of a deployment at a certain point.
Expand Down
Loading