Skip to content

Conversation

@dmatch01
Copy link
Collaborator

@dmatch01 dmatch01 commented Aug 11, 2021

Multi-part Quota Management Integration

Part 1: #132
Part 2: #145
Part 3 (this PR): #147

Summary of Changes

This PR adds the MCAD Quota Library and RP Manager component illustrated in the attached component file. Other changes to component are related to renaming. Finally, some changes are related to generating a private build.

Note: Integration requires building with a private tag.

Makefile
Enable private build

deployment/mcad-controller/templates/configmap.yaml
Helm support changes

deployment/mcad-controller/templates/deployment.yaml
Helm support changes

deployment/mcad-controller/values.yaml
Helm support changes

pkg/controller/queuejob/queuejob_controller_ex.go
Quota management and resource plan integration into controller

pkg/controller/quota/quotamanager/qm_lib_backend_with_resplan_mgr.go
Quota management and resource plan integration into controller

..._resplan_mgr/resplanmgr/event_handlers.go
Renaming

...n_mgr/resplanmgr/resource_plan_manager.go
Renaming

..._resplan_mgr/resplanmgr/util/constants.go
Renaming

private.mod
Enable private build

test/e2e/queue.go
Disable private build

test/e2e/quota.go
Support e2e quota testing

test/e2e/util.go
Support e2e quota testing

Screen Shot 2021-08-09 at 12 38 11 PM

Signed-off-by: dmatch01 <darroyo@us.ibm.com>
Signed-off-by: dmatch01 <darroyo@us.ibm.com>
…use wih configmap. Signed-off-by: dmatch01 <darroyo@us.ibm.com>
Signed-off-by: dmatch01 <darroyo@us.ibm.com>
Signed-off-by: dmatch01 <darroyo@us.ibm.com>
Signed-off-by: dmatch01 <darroyo@us.ibm.com>
@dmatch01 dmatch01 changed the title Quota management quota lib int 03 add qm bknd Quota management quota management (qm) lib integration part 03 add qm backend Aug 11, 2021
@dmatch01 dmatch01 changed the title Quota management quota management (qm) lib integration part 03 add qm backend Quota management Part 03 quota management (qm) lib integration add qm backend Aug 11, 2021
@dmatch01 dmatch01 requested a review from atantawi August 11, 2021 13:15
@dmatch01
Copy link
Collaborator Author

/cc @kyleschlosser
@kyleschlosser Please see this PR for final integrate and build changes.

Signed-off-by: dmatch01 <darroyo@us.ibm.com>
@dmatch01 dmatch01 merged commit 96f4158 into project-codeflare:quota-management Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants