Skip to content

Fix build image tag #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Fix build image tag #12

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
315ee56
Fixed image tag to follow RELEASE_VER in makefile.
dmatch01 Oct 22, 2019
939e11d
Merge branch 'master' into fix-build-image-tag
dmatch01 Oct 22, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed image tag to follow RELEASE_VER in makefile. 
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
  • Loading branch information
@dmatch01
dmatch01 committed Oct 22, 2019
commit 315ee566cac190b0c27909b2ff3fc6016513e52c
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ images:
$(info Changed to executable directory)
cd ./_output/bin
$(info Build the docker image)
docker build --no-cache --tag mcad-controller:deleteme -f ${CURRENT_DIR}/deployment/Dockerfile.both ${CURRENT_DIR}/_output/bin
docker build --no-cache --tag mcad-controller:${RELEASE_VER} -f ${CURRENT_DIR}/deployment/Dockerfile.both ${CURRENT_DIR}/_output/bin

run-test:
# hack/make-rules/test.sh $(WHAT) $(TESTS)
Expand Down