Fix keyboard navigation in ListViewTree #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…the tree via keyboard wouldn't resize the containing pane, whereas expanding/collapsing nodes via the arrow handle would. Discovered during see #67792
…pt-ui into treeview-kbd-navigation-67792
cmd on macos, ctrl on others see #75020
see #67792 see #75020
elementalhub pushed a commit that referenced this pull request Aug 25, 2025
* master: Add compiled code Dialog Inline: fix overflow issue and scrollbar issue (fylr only) for the "inline" dialog component. See #77014 Fix keyboard navigation in ListViewTree (#51) Enhances the copyObjectV2 utility method to not fail when the object to copy has promises inside. Now this promises are passed to the new object but not copied. Adds build files Enhance the whenAllReject method to return the rejected promise as argument. See #76577 Add compiled code Root: expose some more theme specific CSS variables so they can be used in a plugin (e.g. geo-json). Add compiled code. Map: invert colors of map search input (combobox) to match the rest of the buttons, place search input at the very top. See #74686 Map: switch positions of the fullscreen button and map style button. See #74686 # Conflicts: # public/cui.min.js
elementalhub pushed a commit that referenced this pull request Sep 2, 2025
* master: Add compiled code List View: adds comments about the usage of list-view with css-grid-layout Add compiled code Input Date: uses CSS variables to determine the min-width of date inputs in a specified date format. See #76989 Add compiled code Dialog Inline: fix overflow issue and scrollbar issue (fylr only) for the "inline" dialog component. See #77014 Fix keyboard navigation in ListViewTree (#51) Enhances the copyObjectV2 utility method to not fail when the object to copy has promises inside. Now this promises are passed to the new object but not copied. Adds build files Enhance the whenAllReject method to return the rejected promise as argument. See #76577 Add compiled code Root: expose some more theme specific CSS variables so they can be used in a plugin (e.g. geo-json). Add compiled code. Map: invert colors of map search input (combobox) to match the rest of the buttons, place search input at the very top. See #74686 Map: switch positions of the fullscreen button and map style button. See #74686 # Conflicts: # public/cui.min.js # public/cui_fylr.css # src/scss/themes/fylr/mixins/_list-view-use-css-grid-layout.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously navigating the tree via keyboard wouldn't resize the containing pane, whereas expanding/collapsing nodes via the arrow handle would.
Discovered during see #67792