Allow DataTable's onRender callback to access the rendered dom element for modification #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
onRender previously was called when the table wasn't rendered yet See #70781
* master: Update build files - A new method has been added to the Label class that allows processing text with a regular expression and adding DOM elements where matches occur. This new function can be used as a text_node_func in labels. An example of this new method is a function that parses the text looking for object IDs and displays links to show these objects in a popover. Add build files Pane Header: make the buttonbar in the pane header more compact. See #72589 Add build files Update Build Files BC Dates: - Adds new formats to the available parsers in DateTimeFormats to allow long bc dates with years with less and more then 4 digits, ex 02/12/24 BC Add compiled code Labels: optimize style for yellow warning label, used very rarely, e.g. linked-objects in expert search. See #75983 Add compiled code Buttons: reset button style for a link button in very special cases (used in custom-data-types). See #75862
Moving super call in render to the end apparently made the whole table unusable Added flag to DataField's render method whether to call onRender callback See #70781
tao-cumplido changed the title 
elementalhub pushed a commit that referenced this pull request Jun 3, 2025
* master: Allow DataTable's onRender callback to access the rendered dom element for modification (#50) # Conflicts: # public/cui.min.js
elementalhub pushed a commit that referenced this pull request Jun 12, 2025
* master: (37 commits) Allow DataTable's onRender callback to access the rendered dom element for modification (#50) Update build files - A new method has been added to the Label class that allows processing text with a regular expression and adding DOM elements where matches occur. This new function can be used as a text_node_func in labels. An example of this new method is a function that parses the text looking for object IDs and displays links to show these objects in a popover. Add build files Pane Header: make the buttonbar in the pane header more compact. See #72589 Add build files Add compiled code Update Build Files BC Dates: - Adds new formats to the available parsers in DateTimeFormats to allow long bc dates with years with less and more then 4 digits, ex 02/12/24 BC Fix mousemove target detection for ListViews ListViews check if a row can be moved by checking properties defined on cell elements of adjacent rows. When a cell contained content that filled the entire cell, the cell itself would never be the direct target anymore. The solution is to query the mousemove target for its closest ancestor that is a cell element. See #70781 whitespace autofixes Add compiled code Labels: optimize style for yellow warning label, used very rarely, e.g. linked-objects in expert search. See #75983 Add compiled code Buttons: reset button style for a link button in very special cases (used in custom-data-types). See #75862 Update build files XHR: Adds support for PATCH method in request in CUI.XHR Icons: add a CSS variable to define the icon font-size. See #75769 Add compiled code Buttons: add simple style for webdvd-player button. See #75297 ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
onRender previously was called when the table wasn't rendered yet
See #70781