Skip to content

Brand color v2 74215 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 19, 2025
Merged

Brand color v2 74215 #48

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b673bb
Vars: tweak default list-view selected color to be a little darker th…
Dec 12, 2024
e0e43ab
List-View: reset hover and selected styles to use the gray color sche…
Dec 12, 2024
783af0d
Add compiled code
Dec 12, 2024
4ae4e4b
Merge branch 'master' into brand-color-v2-74215
Feb 5, 2025
b160239
Label: remove special treatment of the empty label in selected rows, …
Feb 5, 2025
db0db93
Add compiled code
Feb 5, 2025
fca7a7d
Merge branch 'master' into brand-color-v2-74215
novaxpro Feb 19, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
List-View: reset hover and selected styles to use the gray color sche… 
…me. If hover/selected needs to be different override the variables in the theme. See #74215
  • Loading branch information
Stefanie Hein committed Dec 12, 2024
commit e0e43ab869f31ebce8f68b77c21bfee7f51d69f7
8 changes: 5 additions & 3 deletions src/scss/themes/fylr/components/_list-view.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
// selected
--list-view-selected-row-border-width: 0;
--list-view-selected-row-border-color: transparent;
--list-view-selected-row-background: var(--brand-color, #{$list-view-selected-row-background});
--list-view-selected-row-background: #{$list-view-selected-row-background};
// hover
--list-view-hover-row-background: var(--brand-color, #{$list-view-hover-row-background});
--list-view-hover-row-background: #{$list-view-hover-row-background};


min-height: 0;
Expand Down Expand Up @@ -169,7 +169,9 @@
cursor: default;

// be careful to apply a default select state, it's probably best to do this contextually in the theme
&.cui-selected {
&.cui-selected,
&.cui-selected:hover,
&.cui-selected:focus {
> .cui-lv-tr {
box-shadow: inset 0 0 0 var(--list-view-selected-row-border-width) var(--list-view-selected-row-border-color);
background-color: var(--list-view-selected-row-background);
Expand Down