No jquery #1
Closed
No jquery #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- removed jQuery and added jQueryCompat.coffee CUI.DOM - new: children, width, height, append, prepend, empty insertBefore, insertAfter, is, getRelativePosition, setDimension, getDimension - removed: setStylePx, use setStyle instead - getDimensions: new values, borderTop* and offsetTopScrolled, offsetLeftScrolled
- More work for jQuery removal, improved compat layer - copyObject can now copy CUI objects (using CUI.Element::copy) CUI.DOM - New Functions "removeChildren", "replaceWith" - Improved "append", "prepend": they also accept boolean and number now. - Fixed "parents" to really filter parents
- new: "htmlToNodes", turns HTML into a list of Nodes. jQueryCompat - Fixed appendTo and prependTo to return the node the function was called on, not the argument. DateTime - Open Popover with the Button as Positioner, not the Input. Sometimes the Inputs are so wide, that the Popover would be too many mouse miles away from the click. Label - Fixed "markdown" rendering. Uses CUI.DOM.htmlToNodes. - Added a markdown: true demo. Themes.ng - Make cui-label-content flex-direction: column. This fixes various problem we had with flex-direction: row. Our predominant direction is column, so I think this is the better choice. This also allows us to use less "align-self: flex-start" directives.
Conflicts: src/elements/Button/Buttonbar.coffee src/elements/Button/demo/ButtonDemo.coffee
…sed Templates - Improved Internet Explorer compability: Turns out that classList.add|remove only takes one argument on IE. DOM - Have "remove" return the element passed. jQueryCompat - Added "remove" to the compat functions, if not exists (IE does not support "remove") - Pseudo-support "length" on wrapped nodes: this fixes code which does "closest(...).length > 0". - Suppot "attr" like jQuery: set on Array, get on first node only.
- Renamed Element to CUI.Element, Dummy to CUI.Dummy, Layer to CUI.Layer in many places. - copyObject: Copy CUI.Dummy and HTMLElemnts by reference. - copyObject: Output improved error message when Object keys could not be copied. jQueryCompat - Added "parent" to the compat functions - Moved compat warnings to $ and jQuery, no compat warning is issued when jQueryCompat is called directly. - Renamed all $.* calls to CUI.* calls (isFunction, isPlainObject, isEmptyObject) - Added "scrollIntoView" to node-Array supported functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
First design steps