don't rewrite string quotes inside f-strings #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
espressif-bot pushed a commit to espressif/esp-idf-size that referenced this pull request May 6, 2025
Python 3.12 and later versions support nested strings in f-strings (PEP 701) and have modified the tokenize module. However, this update was not incorporated into the double-quote-string-fixer (string_fixer.py) hook of pre-commit. The issue[1] is resolved[2] in pre-commit version 4.5.0[3]. Upgrade to pre-commit 4.5.0 to prevent incorrect reformatting of f-strings. [1] pre-commit/pre-commit-hooks#971 [2] https://github.com/pre-commit/pre-commit-hooks/blob/main/CHANGELOG.md#450---2023-10-07 [3] pre-commit/pre-commit-hooks#973 Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
resolves #971