Skip to content

Conversation

SaloniThete
Copy link
Contributor

Related Issue #196

Issue Name : Heart Failure Prediction
Closes #196

  • Hacktoberfest2021 Participant
  • Contributor

Description

  • Added Jupyter Notebook for Heart Failure Prediction
  • Added README.md

Type of Change:

What sort of change have you made:

  • New feature (non-breaking change which adds functionality)

Checklist:

My code follows the guidelines of this project.

  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added test cases that prove my fix is effective or that my feature works.
    @prathimacode-hub please review the PR
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done :

Add purpose, worklow of the project, what you had done in README.md
Add all imported libraries in "requirements.txt" file
Add some of the data visualizations in README.md file.

Kindly do these changes. @SaloniThete

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 14, 2021
@SaloniThete
Copy link
Contributor Author

Required changes are done. Added workflow to Readme, added the Requirements file. the data visualization is a bit way lengthy to be added in the readme but has been mentioned in the workflow.
@prathimacode-hub , kindly review the PR

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding data visualizations means mentioning links here, not elaborating in text. @SaloniThete

@SaloniThete
Copy link
Contributor Author

SaloniThete commented Oct 14, 2021

I understand that I have to add the links of data visualizations, but there are more than 10 links, which will make the README.md longer than it has to be.
@prathimacode-hub

@prathimacode-hub
Copy link
Owner

I understand that I have to add the links of data visualizations, but there are more than 10 links, which will make the README.md longer than it has to be. @prathimacode-hub

Don't need to add full. Add few samples. @SaloniThete

@SaloniThete
Copy link
Contributor Author

Sure. I have added few samples of Data Visualizations too. kindly Review the PR
@prathimacode-hub

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Impressive work. Well done. 👍👌@SaloniThete

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest label Oct 21, 2021
@prathimacode-hub prathimacode-hub merged commit 9865e25 into prathimacode-hub:main Oct 21, 2021
@welcome
Copy link

welcome bot commented Oct 21, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants