Skip to content

Conversation

singhmansi25
Copy link
Contributor

Related Issue: #1095

  • Hacktoberfest2022 Participant

  • Contributor

Closes: #1095

Description
We will be scraping data from Flipkart website and then will use the data to create a DataFrame, which used for data analysis.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)

How Has This Been Tested?
I have self verified the codes.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly where ever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots
Screenshots are attached for reference.

@singhmansi25
Copy link
Contributor Author

@prathimacode-hub
Please review my PR

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 15, 2022
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done :

Write your project folder as "Flipkart Mobiles Scraping"
Rename the readme file as README.md
Add the scraped project file in .py format rather than .ipynb

Kindly do these changes. @singhmansi25

@prathimacode-hub prathimacode-hub added the Request Changes Requesting for changes in PR label Oct 15, 2022
@singhmansi25
Copy link
Contributor Author

@singhmansi25
Copy link
Contributor Author

@prathimacode-hub
Please review my PR again.

@singhmansi25
Copy link
Contributor Author

@prathimacode-hub
Please review my PR

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Well done. 👍👏@singhmansi25

@prathimacode-hub prathimacode-hub added HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest Approved This PR is approved and removed Request Changes Requesting for changes in PR labels Oct 30, 2022
@prathimacode-hub prathimacode-hub merged commit baf0857 into prathimacode-hub:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved This PR is approved HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants