Skip to content

Conversation

@benc-uk
Copy link

@benc-uk benc-uk commented Mar 15, 2020

Made printer and validator their own module scopes, by placing them in separate files

As per this comment microsoft/TypeScript#16785 (comment) I believe this is the correct way to do this

This resolves the "Invalid module name in augmentation" error I was seeing in my project #7

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #8 +/- ## ======================================= Coverage 87.21% 87.21% ======================================= Files 5 5 Lines 391 391 ======================================= Hits 341 341 Misses 50 50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7c5ba...18daf7d. Read the comment docs.

@benc-uk benc-uk closed this Oct 19, 2020
@prantlf
Copy link
Owner

prantlf commented Mar 5, 2023

I went for a little different approach - a single index.d.ts to be match it with types in package.json too. But thank you for the idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants