Skip to content

update rust version in docker image #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2024
Merged

update rust version in docker image #762

merged 1 commit into from
Jun 24, 2024

Conversation

adriangb
Copy link
Contributor

@adriangb adriangb commented Jun 24, 2024 •
edited
Loading

@adriangb
Copy link
Contributor Author

cc @levkk
@adriangb
Copy link
Contributor Author

I tested this and it built locally. That said it did also build before this change but I think it was because it was defaulting to this version due to lack of pin.
@levkk levkk merged commit 88dbcc2 into postgresml:main Jun 24, 2024
@adriangb adriangb deleted the fix-docker branch June 24, 2024 15:52
@adriangb
Copy link
Contributor Author

Seems like this didn't work: https://github.com/postgresml/pgcat/actions/runs/9648450240/job/26609660013

There must be some sort of CI cache going on.
@lobaorn
Copy link

lobaorn commented Jun 26, 2024 •
edited
Loading

Hi @adriangb @levkk it is not a CI cache, it is the checkout action version in the workflow. See:

actions/checkout#1464

actions/checkout#1596

actions/checkout#1674

I believe that by just upgrading the workflow version it should be fine.

Edit: I went to check, it was not because of what I said, that part was solely a warning still, I do not think it will solve it.

Edit2: I guess it is because of this file that was not updated since https://github.com/postgresml/pgcat/blob/main/Dockerfile.ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@adriangb @lobaorn @levkk