Add more metrics to prometheus endpoint #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
magec force-pushed the improve-prometheus-metrics branch from 69409da to 9a8782f Compare This change: - Adds server metrics to prometheus endpoint. - Adds database metrics to prometheus endpoint. - Adds pools metrics to prometheus endpoint. - Change metrics name to have a prefix of (stats|pools|databases|servers).
magec force-pushed the improve-prometheus-metrics branch from 9a8782f to 4088faf Compare | Will make some changes before. |
| Ok, I changed some labels that read 'database' to pool, because they were mistakenly set. Also, now PrometheusMetric is implemented using generics, because values are sometimes |
| Could not reopen this one, opened a new PR (#263) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently prometheus endpoint only outputs metrics related with 'stats' (those shown in a SHOW STATS admin command).
This change:
This change is not backward compatible as metric names are now prefixed. Maybe we can leave current metric names 'as is' and add prefixes only for the new stuff, but I like it more with everything prefixed.
/cc @dat2