- Notifications
You must be signed in to change notification settings - Fork 24
feat: listMessageLogs [messaging] #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please resolve conflicts |
are there any problems with this pull request? |
return response; | ||
} else { | ||
throw AppwriteException("Error listing message logs. Status code: " + | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the } ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be deleted when i tried to resolve conflicts ,should i create another pull request for this function or how can i add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to create another pull request, do your changes in this branch and push into the same branch itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this closing brace is already added in my code ,i think it's deleted while i'm trying to resolve the conflicts,i'll try to make any small changes in the function and push it again with the brace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
6e19e71
to f489565
Compare Does it need any other modifications, or is it okay? |
I hope everything is still fine and I didn’t mess anything up |
okay will verify and test once. |
When i test it with a message, I cannot the logs of the messages, can you show me the screenshots of appwrite console and ids you're using to fetch the logs? @basant20415 |
okay testing. |
is everything okay in the function? |
yes thank you. |
here is the output of the function

if you need any other modification ,please let me know