Refactored get-spo-invalid-user-accounts script README.md #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1. Modular Functions - Get-AllUsersFromUPA, Get-DisabledUsersFromGraph, and Validate-SiteUsers encapsulate logic for clarity and reusability. 2. Readable Loops - Flattened loops and replaced nested if logic with clear conditions. 3. Pipeline-Friendly - Uses ForEach-Object and -contains for clean collection handling. 4. Error Handling - Each user retrieval is wrapped in try/catch to prevent the script from stopping. 5. Color-Coded Output - Yellow for warnings, Red for errors, Green for completion. 6. Easy to Extend - Adding additional validation rules is straightforward within Validate-SiteUsers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Modular Functions - Get-AllUsersFromUPA, Get-DisabledUsersFromGraph, and Validate-SiteUsers encapsulate logic for clarity and reusability.
Readable Loops - Flattened loops and replaced nested if logic with clear conditions.
Pipeline-Friendly - Uses ForEach-Object and -contains for clean collection handling.
Error Handling - Each user retrieval is wrapped in try/catch to prevent the script from stopping.
Color-Coded Output - Yellow for warnings, Red for errors, Green for completion.
Easy to Extend - Adding additional validation rules is straightforward within Validate-SiteUsers.