Detect when " Convolution effects cannot be merged " happens

[vis-prime]

Whats an easy way to detect a convolution effect exists in composer.passes so that I can make programmatically make a new effectPass when adding another convolution effect ?

eg: Chromatic Abberration and SMAA

[vanruesc]

Sorry for the late response! I don't think there's a way to detect this currently. You could try copy&pasting the EffectAttribute check into your app as a workaround:

let attributes: EffectAttribute = EffectAttribute.NONE; for(const effect of effects) { if(attributes & effect.getAttributes() & EffectAttribute.CONVOLUTION) !== 0) { // Convolution effect conflict. } attributes |= effect.getAttributes(); }

I'll add a way to access this information in v7.

[vanruesc]

I'll add a way to access this information in v7.

FYI: In v7 it's possible to detect whether effects can be merged by simply attempting to set effectPass.effects inside a try-catch block. The setter will throw if the combination is invalid.

postprocessing/src/passes/EffectPass.ts

Lines 111 to 136 in 7e61527

	/**
	* The effects.
	*
	* @throws If there are duplicate effects or if the effects cannot be merged.
	*/
	get effects(): readonly Effect[] {
	return this.subpasses as readonly Effect[];
	}
	protected set effects(value: Effect[]) {
	const distinctEffects = new Set(value);
	if(distinctEffects.size < value.length) {
	const duplicates = value.filter(x => !distinctEffects.has(x)).map(x => x.name);
	throw new Error(`Encountered duplicate effects: ${duplicates.join(", ")}`);
	}
	this.subpasses = value;
	}