Skip to content

Conversation

@BSd3v
Copy link
Contributor

@BSd3v BSd3v commented Dec 30, 2024

Attempting to make polling requests not eat bandwidth

This is to fix #3111

@gvwilson gvwilson added feature something new community community contribution labels Jan 3, 2025
@gvwilson
Copy link
Contributor

gvwilson commented Jan 3, 2025

@T4rk1n can you please review? thx

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just have a question if we could just do body = "{}" if we have the cache key instead of setting the inputs to null, think that might require some work on the backend callback but wouldn't it be better?

@BSd3v
Copy link
Contributor Author

BSd3v commented Jan 6, 2025

@T4rk1n,

This would indeed take much more effort to unwind how the background callbacks function to completely strip the need for the input structure, as this is used to verify the callback structure, as well as pull things like context (I'm assuming for using things like progress updates)


If we want to do this in a rework, it should probably be done with my other open PR, as this will require a much more lengthy refactor. This PR however wouldnt require a rework and would solve the issue with lengthy data being passed to the backend when unnecessary.

@T4rk1n
Copy link
Contributor

T4rk1n commented Jan 6, 2025

This would indeed take much more effort to unwind how the background callbacks function to completely strip the need for the input structure, as this is used to verify the callback structure, as well as pull things like context (I'm assuming for using things like progress updates)

It's fine like this, I don't think the refactor is really worth the effort for now.

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, thank you.

@T4rk1n
Copy link
Contributor

T4rk1n commented Mar 25, 2025

table-node failed with unrelated npm connection error, merging.

@T4rk1n T4rk1n merged commit 5dc9a11 into plotly:dev Mar 25, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community community contribution feature something new

3 participants