Bugfix: Graph component becomes unresponsive if an invalid figure is passed #3103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
KoolADE85 requested review from T4rk1n, alexcjohnson, emilykl, gvwilson and ndrezn as code owners 
KoolADE85 force-pushed the bugfix/graphs-with-empty-figure branch from a620a16 to 2a640fb Compare 
T4rk1n approved these changes Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a
Graphwith an invalid figure prop (for example,figure=None) would remain broken even after being updated to a valid figure.See the integration test for an example Dash app that is fixed here.
Fixes https://github.com/plotly/notebook-to-app/issues/2065
Contributor Checklist
optionals
CHANGELOG.md