Add request data to callback_context #3051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
T4rk1n requested review from alexcjohnson, emilykl, gvwilson and ndrezn as code owners 
gvwilson approved these changes Oct 23, 2024
| triggered_inputs=callback_ctx.triggered_inputs, | ||
| ignore_register_page=True, | ||
| ), | ||
| ctx_value, |
There was a problem hiding this comment.
When I try to run this with a background task, I get a callback error of kombu.exceptions.EncodeError: Object of type Response is not JSON serializable. It works if I pop 'dash_response' and 'background_callback_manager' from this dict though
There was a problem hiding this comment.
Do we have any automated tests for background tasks to help catch this...?
There was a problem hiding this comment.
Ah @T4rk1n I see you added one. Nice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #2235
Add the following properties from
flask.requesttocallback_context: