Skip to content

2099 dropdown search #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2022
Merged

2099 dropdown search #2104

merged 4 commits into from
Jun 28, 2022

Conversation

@T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jun 23, 2022 •
edited by alexcjohnson
Loading

Disable value reset if not in options if the Dropdown searchable=True to fix the search value in the input resetting when a value is selected and a new search is typed. Fix #2099

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR
  • I have added entry in the CHANGELOG.md
@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner June 23, 2022 17:57
@alexcjohnson
Copy link
Collaborator

alexcjohnson commented Jun 27, 2022

@T4rk1n this looks great as far as #2099 is concerned, but I wonder if #2072 will be another layer on top of this or if it indicates we want another approach entirely?
@T4rk1n
Copy link
Contributor Author

T4rk1n commented Jun 27, 2022

@alexcjohnson #2072 is a similar bug but it is not fixed by this PR.
alexcjohnson
alexcjohnson approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@T4rk1n T4rk1n merged commit d558862 into dev Jun 28, 2022
@T4rk1n T4rk1n deleted the 2099-dropdown-search branch June 28, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@T4rk1n @alexcjohnson