Skip to content

Conversation

@nachomata
Copy link

This pull request includes changes to handle long command lines on Windows by creating a response file when necessary, addressing issue #4446. It is solved by creating a response file when necessary, as suggested here.

Changes made:

This is just a quick fix addressing the immediate problem. It might need some extra testing and fine-tuning, so any suggestions would be welcome.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

@ivankravets ivankravets requested a review from valeros March 11, 2025 19:41
@ivankravets ivankravets added this to the 6.1.19 milestone Mar 11, 2025
@valeros
Copy link
Member

valeros commented Mar 13, 2025

Hi @nachomata, thanks for the PR. I'm afraid none of our backend tools for static code analysis (cppcheck, clang-tidy) supports response files at the moment. For cppcheck we already use the --includes-file option that helps shorten the final command line. As for clang-tidy, there is indeed similar option called @parameters_file, but it seems this option cannot be used to pass compilation options (defines, include paths, etc.).

@ivankravets ivankravets removed this from the 6.1.19 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants