Skip to content

Conversation

@dgraham
Copy link
Member

@dgraham dgraham commented Aug 9, 2022

A little cleanup to encoding binary as hex.

@dgraham dgraham requested a review from iheanyi August 9, 2022 16:50
Copy link
Contributor

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

dgraham and others added 6 commits August 9, 2022 12:03
Co-authored-by: iheanyi <iheanyi@users.noreply.github.com>
Co-authored-by: iheanyi <iheanyi@users.noreply.github.com>
We don't have enough information to determine if the binary string contains UTF-8 bytes, so pass it through as-is and allow the caller to process it. Co-authored-by: iheanyi <iheanyi@users.noreply.github.com>
Allow the caller to inspect the column data types. Co-authored-by: iheanyi <iheanyi@users.noreply.github.com>
Export a binary-to-hex string encoding function so callers can format binary strings for display. Co-authored-by: iheanyi <iheanyi@users.noreply.github.com>
Co-authored-by: iheanyi <iheanyi@users.noreply.github.com>
Copy link
Contributor

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🍐 ing session

@dgraham dgraham merged commit 1861a9d into main Aug 9, 2022
@dgraham dgraham deleted the text-map branch August 9, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants