compose-cli compat #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Minor updates to syntax to make it compatible with the new compose-cli written in Go, it has some slightly different YAML constraints with booleans and also a change with the external network definition.
I've also removed the watchtower volume for the Docker config. It's only necessary for private repos. It would be nice to have as a default but a fresh clone results in no config so the mount mechanism auto-creates a directory by default (wtf?) and mounts that, so watchtower ends up spamming errors about config.json being a directory instead of a file... wisedom.