Allow future dates in prettyDate #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I was inspired to extend prettyDate to allow future dates after I was getting a heisenbug with a date that was a few milliseconds ahead of my browser's time, causing the function to return undefined until I observed it in a debugger. Now, in addition to previous formats, you can get: * in a moment * x minute(s) from now * x hour(s) from now * Tomorrow * x day(s) from now * x week(s) from now * more than 5 weeks from now
Hours and minutes still need to be covered at some point
| I'll leave this open while I fix errors |
phstc added a commit that referenced this pull request Mar 14, 2016
Allow future dates in prettyDate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was inspired to extend prettyDate to allow future dates after I was getting a heisenbug with a date that was a few milliseconds ahead of my browser's time, causing the function to return undefined until I observed it in a debugger.
Now, in addition to previous formats, you can get: