+ Bugfix for 'm' and 's' #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hey @shaan1337 Thanks for the contribution. Could you merge master into your branch to fix the errors in Travis CI? It needs this commit to work in Travis. |
@shaan1337 could you detail more the debug? How's it before/after the change? WDYT about adding a test in here to "document" the expected behavior? |
| @phstc i'm sorry for the late reply. I'm having some issues with 'npm install' so I've just committed the modified source file and added a test as requested (dist files are untouched) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed leading 0 bug with 'm' and 's'