Add stub for form options #419
Conversation
VincentLanglet force-pushed the formOptions branch 4 times, most recently from 7c21546 to b8b9ebc Compare 
| | ||
| public function doSomethingWithInvalidOption(): void | ||
| { | ||
| $form = $this->formFactory->create(DataClassType::class, new DataClass(), ['required' => 42]); |
There was a problem hiding this comment.
I'd like to get an error here saying I pass an integer when a string is expected because DataClassType is
AbstractType<DataClass, array{required: string, optional: int}> I thought it would have been reported by the CallMethodsRuleTest.
What do I miss @ondrejmirtes ?
There was a problem hiding this comment.
Please recreate the scenario in a minimal way on phpstan.org/try so I don't have to hold all the interfaces and Symfony classes in my head.
There was a problem hiding this comment.
Sure.
You already helped me with phpstan/phpstan#12372 (comment).
But I discovered that in Symfony, that the required options in the Factory::create methods and the certains options in the buildForm $options are not exactly the same.
So this would give something like
https://phpstan.org/r/2fc552e7-506e-46a5-aba0-69287a5b8d3e
I dunno if it's possible to have something better than
@implements FormTypeInterface< * object, * array{required: string, optional?: int, defined?: bool}, * array{required: string, optional: int, defined?: bool} * > b8b9ebc to 289e279 Compare 
VincentLanglet force-pushed the formOptions branch from 289e279 to d5960d8 Compare 
| | ||
| /** | ||
| * @template TData | ||
| * @template TOptions of array<string, mixed> |
There was a problem hiding this comment.
This has to be optional, otherwise it's a BC break. See phpstan/phpstan-src#3457
2 participants
No description provided.