Skip to content

Introduce uppercase-string #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 20, 2024
Merged

Introduce uppercase-string #3613

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
15551b1
Introduce uppercase-string
pmjones Nov 1, 2024
09dff31
Update src/Type/Php/ParseUrlFunctionDynamicReturnTypeExtension.php
pmjones Nov 8, 2024
c0236db
fix name collision
pmjones Nov 8, 2024
d60c48a
resolve failing test on 7.4
pmjones Nov 8, 2024
f0e552c
reasons are now unique
pmjones Nov 10, 2024
44a544f
remove unused constant
pmjones Nov 10, 2024
ccbf6ad
resolve feedback
pmjones Nov 18, 2024
6378810
resolve feedback
pmjones Nov 18, 2024
cfc2a86
resolve feedback
pmjones Nov 18, 2024
774ff21
resolve feedback
pmjones Nov 18, 2024
6ecbc0b
resolve feedback
pmjones Nov 18, 2024
46f45e7
resolve feedback
pmjones Nov 18, 2024
7bb56a8
resolve feedback
pmjones Nov 18, 2024
b861d01
resolves feedback
pmjones Nov 18, 2024
c92d7b2
resolve feedback
pmjones Nov 18, 2024
78e136e
resolve feedback
pmjones Nov 18, 2024
d4056d1
resolve feedback
pmjones Nov 18, 2024
ebd50a3
add extension files from @VincentLanglet
pmjones Nov 19, 2024
96830fd
cs fixes
pmjones Nov 19, 2024
b4395b2
check both lower and upper, not just the one (thanks phpstan!)
pmjones Nov 19, 2024
356e0f8
remove uppercase-string from parse_url()
pmjones Nov 19, 2024
4c54a1a
resolve linting on lower PHP versions
pmjones Nov 19, 2024
668d970
resolve linting on lower PHP versions
pmjones Nov 19, 2024
96773a4
add type combinator tests
pmjones Nov 19, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve feedback 
Addresses #3613 (comment), #3613 (comment), #3613 (comment)
  • Loading branch information
@pmjones
pmjones committed Nov 19, 2024
commit 6ecbc0bf49b73978e5fee9c522e70ac43e6a6c59
6 changes: 3 additions & 3 deletions stubs/core.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,17 +321,17 @@ function is_callable(mixed $value, bool $syntax_only = false, ?string &$callable
function abs($num) {}

/**
* @return ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string))
* @return ($string is lowercase-string&uppercase-string ? lowercase-string&uppercase-string : ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string)))
*/
function trim(string $string, string $characters = " \n\r\t\v\x00"): string {}

/**
* @return ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string))
* @return ($string is lowercase-string&uppercase-string ? lowercase-string&uppercase-string : ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string)))
*/
function ltrim(string $string, string $characters = " \n\r\t\v\x00"): string {}

/**
* @return ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string))
* @return ($string is lowercase-string&uppercase-string ? lowercase-string&uppercase-string : ($string is lowercase-string ? lowercase-string : ($string is uppercase-string ? uppercase-string : string)))
*/
function rtrim(string $string, string $characters = " \n\r\t\v\x00"): string {}

Expand Down