RegexArrayShapeMatcher - Support 'n' modifier #3271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @Seldaek with this PR we can now take regex pattern modifiers into account. |
| This pull request has been marked as ready for review. |
| Thank you! Please next time instead of separate commits, send separate PRs. |
Seldaek reviewed Jul 27, 2024
| return null; | ||
| } | ||
| | ||
| if ($delimiter === '{') { |
There was a problem hiding this comment.
() and [] are also valid reciprocal delimiters.
<> too but that's a shitty one to use really.. Still probably should support for completeness
https://www.php.net/manual/en/regexp.reference.delimiters.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
review commit by commit