Implement bit shift operation on integers and unions #3145
Conversation
thg2k force-pushed the pr/shift_range_adv_1 branch 4 times, most recently from d882aa9 to db47c34 Compare 
| This pull request has been marked as ready for review. |
| @ondrejmirtes I played with this feature for a few days in my codebase and I feel it is ready to go. Can you review this? Is there anythink that I'm overlooking? |
There was a problem hiding this comment.
Please add ShiftLeft and ShiftRight here, instead of removing the PHPDoc.
There was a problem hiding this comment.
Done for both. This should lead to a unreachable statement for the "else" branch, not sure if that is a problem.
There was a problem hiding this comment.
This should lead to
It doesn't in bleeding edge. PHPStan no longer penalizes for unreachable else branch that throws an exception.
There was a problem hiding this comment.
Please add ShiftLeft and ShiftRight here, instead of removing the PHPDoc.
| Please note that this would conflict with #3152 if it gets merged. That should have the priority as I think it's a bad bug. I'm happy to rebase this (or the other) in case. |
ondrejmirtes force-pushed the pr/shift_range_adv_1 branch from 36171c3 to a42834d Compare 
| Thank you. |
3 participants
This was in my wishlist for a long time.. so I did it 😄