Add rule to check for existing classes, type aliases and shadowing of generic callables in properties. #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mad-briller force-pushed the genericcallables-properties branch from 24da3c3 to 10a6d28 Compare 
| is there a way to disable the |
mad-briller force-pushed the genericcallables-properties branch from 10a6d28 to 7ec12df Compare 
tests/PHPStan/Rules/PhpDoc/data/generic-callables-incompatible.php Outdated Show resolved Hide resolved
mad-briller force-pushed the genericcallables-properties branch 2 times, most recently from 9c8bff7 to 5f9468b Compare 
… generic callables in properties.
mad-briller force-pushed the genericcallables-properties branch from 5f9468b to 0226579 Compare 
| Thank you! |
| Currently without a dev env to continue on with the other steps, I'll try to follow up when I get one sorted |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
another follow up to: #2938 (review)
covers native properties