Skip to content

Mark more method with phpstan-impure #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

Mark more method with phpstan-impure #685

merged 1 commit into from
Oct 6, 2025

Conversation

@VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Oct 3, 2025

Similar to #648 but with more methods

  • find method exists in EntityManager/DocumentManager
  • find/findOne exists in DocumentRepository
  • findAll/findBy/count are also technically impure the same way find is
@ondrejmirtes ondrejmirtes merged commit 8f083bf into phpstan:2.0.x Oct 6, 2025
35 of 37 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Oct 6, 2025

Thank you!
@VincentLanglet VincentLanglet mentioned this pull request Nov 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@VincentLanglet @ondrejmirtes