Skip to content

Detect deprecated methods from the interface as well. Fix #48 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eiriksm wants to merge 3 commits into from
Closed

Detect deprecated methods from the interface as well. Fix #48 #49

eiriksm wants to merge 3 commits into from

Conversation

@eiriksm
Copy link
Contributor

@eiriksm eiriksm commented Nov 20, 2021

No description provided.

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Nov 20, 2021

Hi, this ought to be rather fixed in https://github.com/phpstan/phpstan-src/blob/eb074fdc9a70542c9d227b26a89031aeeeca7943/src/PhpDoc/ResolvedPhpDocBlock.php#L193 - it should be merged from parent docblocks as well, see for example how the throwsTag is handled above.

Can be tested for example in ClassReflectionTest by getting $this->createReflectionProvider(), and getting the class method in question to see if PHPStan considers it deprecated as well.
@eiriksm eiriksm mentioned this pull request Nov 20, 2021
Merged
@eiriksm
Copy link
Contributor Author

eiriksm commented Nov 20, 2021

Sounds even better. Created here: phpstan/phpstan-src#792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@eiriksm @ondrejmirtes