Skip to content

Conversation

@DanielEScherzer
Copy link
Contributor

No description provided.

@DanielEScherzer
Copy link
Contributor Author

Hmm, seems like this wasn't enough?

@ondrejmirtes
Copy link
Member

I'd like you to try stop guessing and actually test your changes 😊

@DanielEScherzer
Copy link
Contributor Author

DanielEScherzer commented Aug 20, 2025

I don't have a local environment set up where I can test this, and I thought it was going to be a quick change for just the number of attributes, and then it was a quick change for fixing the variable name, but yeah, that would be a good idea

In my defense, I didn't expect the patches to be merged so quickly

@ondrejmirtes
Copy link
Member

I just added a way to see the diff in pull requests. Here you can see what your changes were doing: https://github.com/phpstan/php-8-stubs/actions/runs/17108049204/job/48522046160

So you can send in any changes and you'll see the effect in CI, enabling you to debug them.

@ondrejmirtes
Copy link
Member

It's under "show diff".

@DanielEScherzer
Copy link
Contributor Author

Thanks - I was doing something similar by manually running the actions on my fork, but your way is easier

@DanielEScherzer
Copy link
Contributor Author

Did you just do a force push? I agree that it would be good, it just threw me off for a minute

@ondrejmirtes
Copy link
Member

Yeah I did. You can git rebase --onto your changes onto current origin/main, or simply cherry pick them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants