Add User-Agent header to CURL requests #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I'm not sure why the build is failing. Seems to be something unrelated to the changeset in this PR. |
| @andyexeter Yes, it's not related to your changes. I will check it and fix before the next release. |
| I know it's been a while since we've had any activity here, but Shopify would love to see this merged. When we're deciding where to put our hours in the open source library community, it helps to know which libraries are already being used! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When making many requests over a short period we have noticed Shopify's API sometimes returns a 403 Forbidden error response for requests that usually work.
I have researched this and believe the requests are being caught by some kind of automated request filtering system on Shopify's servers.
Adding a User-Agent header to all CURL requests resolves this issue. I guess their automated system sees the User-Agent header and assumes it is a valid request instead of some sort of scraper.
Relevant discussion: https://ecommerce.shopify.com/c/shopify-apis-and-technology/t/suddenly-getting-forbidden-request-error-from-shopify-with-curl-411472