Better approach to leaky bucket rate limit #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| i'm also highly interested in this. i was about to integrate it myself too. i would at least like to be able to get the http response code. |
talisman-innovations force-pushed the master branch from 1c61c97 to cf7a203 Compare 
| @tareqtms I've posted an updated, slightly cleaned up version. Any chance you can merge this so I can avoid supporting another fork and other people can use this as well? Regards Steve |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi
In our application we can have multiple processes connecting to Shopify simultaneously. In this case the approach currently taken to manage the leaky bucket rate limit doesn't work and 429 errors can be thrown. An alternative approach is to catch the 429 and back off for 0.5 seconds and try again. This works well for us for those times when a small flurry of parallel connection exhaust the bucket.
Regards
Steve