[TASK] handle section creation in NodeTransformer #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
linawolf force-pushed the bugfix/mdsections branch 2 times, most recently from 211e010 to ed95dc6 Compare linawolf changed the title 
jaapio reviewed Feb 19, 2024
There was a problem hiding this comment.
This looks very good, I do like how the introduction of a class like this can have impact on how the AST looks like.
I do have some questions on how we might be able to improve the code a bit, By adding an early exit we might be able to make it a bit more readable, as what I understand the leaveNode is only applicable when the current node is a title node?
packages/guides/src/Compiler/NodeTransformers/SectionCreationTransformer.php Outdated Show resolved Hide resolved
packages/guides/src/Compiler/NodeTransformers/SectionCreationTransformer.php Outdated Show resolved Hide resolved
packages/guides/src/Compiler/NodeTransformers/SectionCreationTransformer.php Outdated Show resolved Hide resolved
linawolf force-pushed the bugfix/mdsections branch from 443c8fc to 16f382c Compare 
To prevent unexpected replacements we need to just replace when something is acually changed.
jaapio force-pushed the bugfix/mdsections branch from 16f382c to 060bb46 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For now this only affects Mark Down Documents, we might want to remove the haky section handling in rest section handling
resolves #842