ext/sockets: UDP_SEGMENT support. #18213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
UDP segmentation offload is an optimisation attempt by sending multiple large enough datagrams over UDP which reduces syscalls as by default, they have to be broke down in small UDP packets, it is better if the hardware supports it, other handed down to the software implementation.
devnexen force-pushed the socket_udp_segment branch from 6edeb94 to 0d040dd Compare 
ndossche reviewed May 22, 2025
| } | ||
| #endif | ||
| | ||
| #if defined(UDP_SEGMENT) |
Member
There was a problem hiding this comment.
This option is only valid for level==SOL_UDP, right? If so, don't we need to check that in this case too?
Member Author
There was a problem hiding this comment.
errno is set in this case.
$src = socket_create(AF_UNIX, SOCK_DGRAM, 0); var_dump(socket_setopt($src, SOL_TCP, UDP_SEGMENT, 2)); var_dump(socket_strerror(socket_last_error()));Warning: socket_setopt(): Unable to set socket option [95]: Operation not supported in /home/dcarlier/Contribs/php-src/a.php on line 3 bool(false) string(23) "Operation not supported" ndossche approved these changes May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
UDP segmentation offload is an optimisation attempt by sending multiple large enough datagrams over UDP which reduces syscalls as by default, they have to be broke down in small UDP packets, it is better if the hardware supports it, other handed down to the software implementation.