Skip to content

Fix GH-13789 build failed mbstring_arginfo.h when Visual C++ on Windows #13906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Fix GH-13789 build failed mbstring_arginfo.h when Visual C++ on Windows #13906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix GH-13789 build failed mbstring_arginfo.h when Visual C++ on Windows 
Probably CP932 environment can't compile. So add /utf-8 flag.
  • Loading branch information
@youkidearitai
youkidearitai committed Apr 7, 2024
commit 22dcba99c10458674f9aea88b786122fc6e3e95c
2 changes: 2 additions & 0 deletions ext/mbstring/config.w32
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ if (PHP_MBSTRING != "no") {
ADD_FLAG("CFLAGS_MBSTRING", "-Iext/mbstring -Iext/mbstring/libmbfl -Iext/mbstring/libmbfl/mbfl \
/D HAVE_STRICMP /D MBFL_DLL_EXPORT=1 /DZEND_ENABLE_STATIC_TSRMLS_CACHE=1")

ADD_FLAG("CFLAGS_BD_EXT_MBSTRING", "/utf-8")

FSO.CopyFile("ext\\mbstring\\libmbfl\\config.h.w32",
"ext\\mbstring\\libmbfl\\config.h", true);

Expand Down