Skip to content

Implement ReflectionConstant #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Implement ReflectionConstant #13669

wants to merge 2 commits into from

Conversation

iluuu1994
Copy link
Member

Fixes GH-13570
@iluuu1994 iluuu1994 requested a review from kocsismate as a code owner March 11, 2024 00:22
@iluuu1994 iluuu1994 changed the title Implement reflection constant Implement ReflectionConstant Mar 11, 2024
@iluuu1994 iluuu1994 mentioned this pull request Mar 11, 2024
Closed
iluuu1994
iluuu1994 commented Mar 11, 2024
View reviewed changes
mvorisek
mvorisek reviewed Mar 11, 2024
View reviewed changes
@nielsdos
Copy link
Member

Some reflection classes also have a name property, such that dumping it somewhere makes it easy to see what it refers to. Does it make sense to add it here too?
staabm
staabm reviewed Mar 11, 2024
View reviewed changes
arnaud-lb
arnaud-lb reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most Reflection classes implements Reflector and provide a __toString() method. I think that's useful and we could implement that for ReflectionConstant as well (using _const_string()).
@iluuu1994 iluuu1994 force-pushed the reflection-constant branch from 717bf13 to d44ce02 Compare March 11, 2024 16:42
arnaud-lb
arnaud-lb approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
kocsismate
kocsismate reviewed Mar 11, 2024
View reviewed changes
arnaud-lb
arnaud-lb reviewed Mar 12, 2024
View reviewed changes
@kocsismate kocsismate mentioned this pull request Mar 17, 2024
Merged
@iluuu1994 iluuu1994 force-pushed the reflection-constant branch 2 times, most recently from 0f1ec56 to e99930c Compare March 20, 2024 10:44
@iluuu1994 iluuu1994 force-pushed the reflection-constant branch from e99930c to 2b5c527 Compare March 20, 2024 10:51
@iluuu1994 iluuu1994 force-pushed the reflection-constant branch from 2b5c527 to ec751aa Compare March 20, 2024 11:13
Girgias
Girgias approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, and maybe renaming const_ to const_ptr? I find the trailing underscore somewhat weird.
@iluuu1994 iluuu1994 closed this in e23440e Apr 17, 2024
@staabm
Copy link
Contributor

staabm commented Apr 18, 2024

Thank you 🙏
TimWolla added a commit to TimWolla/php-src that referenced this pull request Apr 30, 2024
@TimWolla
Add ReflectionClassConstant::isDeprecated()
9f0b64c 
This is in preparation for php#11293 and for consistency with ReflectionConstant::isDeprecated() that was added in php#13669.
@TimWolla TimWolla mentioned this pull request Apr 30, 2024
Merged
TimWolla added a commit that referenced this pull request Apr 30, 2024
@TimWolla
Add ReflectionClassConstant::isDeprecated() (#14086)
b5ffac7 
This is in preparation for #11293 and for consistency with ReflectionConstant::isDeprecated() that was added in #13669.
@jrfnl jrfnl mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Engine Extension: reflection SAPI: cli
9 participants
@iluuu1994 @nielsdos @staabm @arnaud-lb @alcaeus @Bilge @mvorisek @kocsismate @Girgias