Skip to content

random: Clean up seeding API #13540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 29, 2024
Merged

random: Clean up seeding API #13540

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c92a3bb
random: Expose xoshiro256**'s seeding functions
TimWolla Feb 27, 2024
04cbee6
random: Expose pcgoneseq128xslrr64's seeding functions
TimWolla Feb 27, 2024
c63d81f
random: Expose Mt19937's seeding functions
TimWolla Feb 27, 2024
305f880
random: Expose CombinedLCG's seeding functions
TimWolla Feb 27, 2024
164692b
random: Call php_random_mt19937_seed32 to seed the global Mt19937
TimWolla Feb 27, 2024
e365e70
random: NULL the generic seeding function
TimWolla Feb 27, 2024
ad1fd44
random: Remove the `seed` member from `php_random_algo`
TimWolla Feb 27, 2024
cbcaa05
UPGRADING.INTERNALS
TimWolla Feb 27, 2024
ed18365
random: Remove useless cast in `php_mt_srand()`
TimWolla Feb 27, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
random: Remove useless cast in php_mt_srand()
  • Loading branch information
@TimWolla
TimWolla committed Feb 27, 2024
commit ed18365ad81e0768aa000bf06a6f43c8830f75e0
3 changes: 1 addition & 2 deletions ext/random/random.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,7 @@ PHPAPI double php_combined_lcg(void)
/* {{{ php_mt_srand */
PHPAPI void php_mt_srand(uint32_t seed)
{
/* Seed the generator with a simple uint32 */
php_random_mt19937_seed32(php_random_default_status(), (zend_long) seed);
php_random_mt19937_seed32(php_random_default_status(), seed);
}
/* }}} */

Expand Down