Skip to content

Conversation

@welcoMattic
Copy link
Member

Ref #95

@Nyholm Nyholm self-requested a review May 12, 2017 12:29
@Nyholm
Copy link
Member

Nyholm commented May 12, 2017

Thank you. Would you mind adding the rest of the changelog as well?

### Changed - HTML fixes on profiler page ### Added - Option to not show "unstraslatable" in WebUI - Make sure we fail with an exception if SfTranslation is not enabled - Improved testing ### Fixed - Added translation cache dir on warmup 
@welcoMattic
Copy link
Member Author

Done 👍

@Nyholm
Copy link
Member

Nyholm commented May 12, 2017

Thank you. I'll just wait for traivs.

@welcoMattic
Copy link
Member Author

I just add a little comment in README to precise where load symfony_profiler param. I was load it in config.yml, but I experience some issues during cache:clear on prod env.

symfony_profiler must be enabled only on dev env

@Nyholm
Copy link
Member

Nyholm commented May 12, 2017

Thank you

@Nyholm Nyholm merged commit 1ca7b05 into php-translation:master May 12, 2017
@rvanlaak
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants