Clear the translations cache after editing with Edit In Place #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
damienalexandre force-pushed the bug/63 branch from d1d3aaa to b0409bb Compare 
Nyholm approved these changes Jan 16, 2017
Member
Nyholm left a comment
Nyholm left a comment There was a problem hiding this comment.
Thanks.
One could improve this further by only remove the correct domain.
I do not know any other way of doing this. We should, however, write a warning about this in the docs.
Member
| @damienalexandre, merge if you are happy with it =) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a proposal for cache clearing after translation editing. As the Edit In Place functionality is supposed to be used "live", it was looking "broken" because even if a translation is edited correctly, Symfony still display the old messages until the cache is cleared.
I can't think of any better solution but I do not like this very much, editing the cache directory seems like a hack... 😕
II tried another approach: doing a
touch()on the translation files and calling the warmer, but Symfony Cache implementation for translations don't have any resourceCheckers so it can't work. We have to remove the file for them to be rewritten.About the
name('*.'.$locale.'.*')pattern, I checked and it's compatible with Symfony 2.7 and more.Ref #63