feat: drop twig 2 #513
feat: drop twig 2 #513
Conversation
gimler force-pushed the feature/drop-twig-2 branch 3 times, most recently from ceb1dbc to 9aff264 Compare 
| "php-translation/extractor": "^2.0", | ||
| "nyholm/nsa": "^1.1", | ||
| "twig/twig": "^2.14.4 || ^3.3", | ||
| "twig/twig": "^3.12", |
There was a problem hiding this comment.
We just dropped v2, I think it would be cool to keep the min available version of v3 for a while, WDYT? Or do we use something new that is available since 3.12?
There was a problem hiding this comment.
Seems that 3.12 mostly adds a lot of deprecations in preparation of 4.x: https://github.com/twigphp/Twig/blob/3.x/CHANGELOG#L71
There was a problem hiding this comment.
yes the twig_callable was added with twig 3.12 twigphp/Twig@3156d80
So to fix the mass deprecations we must set the minimum to 3.12
gimler force-pushed the feature/drop-twig-2 branch 2 times, most recently from 9aff264 to 604ecd2 Compare 
| Friendly reminder. Is there anything else to be done? |
| Can we expect merge and new version anytime soon? Thank you very much |
| @ZZromanZZ is this PR blocking you in some kind of way? Can't imagine how dropping support could do that. |
| Ideally, we need to fix tests to be sure nothing is broken with the changes. We can do it here or probably better to do it in a separate PR. Any volunteers for this? Merging and releasing with completely red tests is an unstable way. As soon as we have green tests - I will be happy to merge and release. |
gimler force-pushed the feature/drop-twig-2 branch from 604ecd2 to d5e60d8 Compare gimler force-pushed the feature/drop-twig-2 branch from d5e60d8 to 98088f9 Compare gimler force-pushed the feature/drop-twig-2 branch from 98088f9 to a70c38f Compare | No i will rebase this. I Hope later today |
4 participants
No description provided.