Skip to content

Conversation

@bocharsky-bw
Copy link
Member

@bocharsky-bw bocharsky-bw commented Jan 28, 2022

First of all, because PHP 7.2 EOL was a year ago, see https://www.php.net/supported-versions.php . And second - it should help to fix tests in #466 so we could use PHPUnit 9.5 in all builds

P.S. What about 7.3 support? It's also EOL, but it happened at the end of 2021. I'm fine to keep it for a while though

@welcoMattic
Copy link
Member

I'm in favor of dropping 7.3 support if we plan to release a 0.13. Otherwise (0.12.5), keep 7.3 support

@rvanlaak
Copy link
Member

PHP 7.2 still is 11% of installs: https://packagist.org/packages/php-translation/symfony-bundle/php-stats

That 7.2 is EOL would not nessecarily have to mean that we have to drop support for it. Are there any PHP language features or dependencies that block us from implementing new functionality?

A more predictable path would be to do a major cleanup at a certain moment (cleanup, bump to PHP 8.x, and release 1.x) over dropping support for EOL versions that might still be used now.

@bocharsky-bw
Copy link
Member Author

Hm, then probably I should just close this and #466 for now

@bocharsky-bw
Copy link
Member Author

Hm, I wonder if that 8% of PHP 7.2 use we see in stats https://packagist.org/packages/php-translation/symfony-bundle/php-stats is our CI that test thing? :)

@bocharsky-bw bocharsky-bw deleted the drop-php-72 branch February 4, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants