Skip to content

Suppress deprecations on deprecating legacy services #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2021
Merged

Suppress deprecations on deprecating legacy services #445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72069ea
Suppress deprecations on deprecating legacy services
bocharsky-bw Jun 17, 2021
95023bd
Apply PHP CS Fixer recommendations
bocharsky-bw Jun 17, 2021
907829b
Fix the Kernel version ID number
bocharsky-bw Jun 17, 2021
48620fe
Simplify code: Remove unnecessary var
bocharsky-bw Jun 18, 2021
70518b7
Rename the method to registerDeprecatedServices()
bocharsky-bw Jun 18, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply PHP CS Fixer recommendations
  • Loading branch information
@bocharsky-bw
bocharsky-bw committed Jun 17, 2021
commit 95023bd4dde1dfe8600bd9c98a74349a214ba38c
3 changes: 1 addition & 2 deletions Legacy/LegacyHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public static function getMainRequest(RequestStack $requestStack)
}

/**
* @param ServicesConfigurator $servicesConfigurator
* @param array[string $id, string $parent, ?bool $isPublic] $legacyServices
*/
public static function deprecateServices(ServicesConfigurator $servicesConfigurator, array $legacyServices)
Expand All @@ -42,7 +41,7 @@ public static function deprecateServices(ServicesConfigurator $servicesConfigura
$parent = $legacyService[1];
$isPublic = $legacyService[2] ?? false;

# Declare legacy services to remove in next major release
// Declare legacy services to remove in next major release
$service = $servicesConfigurator->set($id)
->parent($parent);

Expand Down
2 changes: 1 addition & 1 deletion Resources/config/legacy/console.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Translation\Bundle\Command\SyncCommand;
use Translation\Bundle\Legacy\LegacyHelper;

return function(ContainerConfigurator $configurator) {
return function (ContainerConfigurator $configurator) {
$services = $configurator->services();

LegacyHelper::deprecateServices($services, [
Expand Down
2 changes: 1 addition & 1 deletion Resources/config/legacy/edit_in_place.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Translation\Bundle\Translator\EditInPlaceTranslator;
use Translation\Bundle\Twig\EditInPlaceExtension;

return function(ContainerConfigurator $configurator) {
return function (ContainerConfigurator $configurator) {
$services = $configurator->services();

LegacyHelper::deprecateServices($services, [
Expand Down
2 changes: 1 addition & 1 deletion Resources/config/legacy/extractors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Translation\Extractor\Visitor\Php\Symfony\ValidationAnnotation;
use Translation\Extractor\Visitor\Twig\TwigVisitor;

return function(ContainerConfigurator $configurator) {
return function (ContainerConfigurator $configurator) {
$services = $configurator->services();

LegacyHelper::deprecateServices($services, [
Expand Down
2 changes: 1 addition & 1 deletion Resources/config/legacy/services.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Translation\Bundle\Twig\TranslationExtension;
use Translation\Extractor\Extractor;

return function(ContainerConfigurator $configurator) {
return function (ContainerConfigurator $configurator) {
$services = $configurator->services();

LegacyHelper::deprecateServices($services, [
Expand Down